Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActionClientGetter: allow disabling rollbacks after failures #348

Merged

Conversation

joelanford
Copy link
Member

When an install fails, we uninstall the failed release. When an upgrade fails, we rollback to the previous release.

This commit makes it possible to disable that behavior, which results in the latest release being left in a Failed state for the caller to decide how to act.

When an install fails, we uninstall the failed release.
When an upgrade fails, we rollback to the previous release.

This commit makes it possible to disable that behavior, which results in
the latest release being left in a Failed state for the caller to decide
how to act.
@joelanford joelanford enabled auto-merge July 8, 2024 13:31
@joelanford joelanford added this pull request to the merge queue Jul 8, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.47%. Comparing base (08ab7fb) to head (bbba1aa).
Report is 21 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (08ab7fb) and HEAD (bbba1aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (08ab7fb) HEAD (bbba1aa)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #348       +/-   ##
===========================================
- Coverage   85.06%   48.47%   -36.60%     
===========================================
  Files          19       62       +43     
  Lines        1346     2921     +1575     
===========================================
+ Hits         1145     1416      +271     
- Misses        125     1423     +1298     
- Partials       76       82        +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into operator-framework:main with commit 994b1d5 Jul 8, 2024
6 checks passed
@joelanford joelanford deleted the disable-failure-rollbacks branch July 8, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants